haldir or legolas?

[Legolas]

I'd take Haldir, mostly because I find him more attractive than Legolas and less of a "pretty-boy".

You've stumbled into the wrong forum, I believe. There's a forum specifically for discussion of the movies. As far as the book goes, you can imagine Haldir and Legolas as being as attractive as you want them to be, keeping in mind that elves are attractive. The books do not describe Legolas as a 'pretty boy' at all. Someone drew a picture depicting him as such - the picture angered Tolkien. Christopher Tolkien tells us what he had to say in The Book of Lost Tales II:

Long afterwards my father would write, in a wrathful comment on a 'pretty' or 'ladylike' pictorial rendering of Legolas:
'He was tall as a young tree, lithe, immensely strong, able swiftly to draw a great war-bow and shoot down a Nazgul, endowed with the tremendous vitality of Elvish bodies, so hard and resistant to hurt that he went only in light shoes over rock or through snow, the most tireless of all the Fellowship.'